C#: Unify goto completions#1548
Merged
semmle-qlci merged 3 commits intogithub:masterfrom Aug 12, 2019
Merged
Conversation
hvitved
force-pushed
the
csharp/cfg/simplify-goto-completions
branch
from
651e933 to
f56c17f
Compare
calumgrant
approved these changes
Aug 12, 2019
Contributor
calumgrant
left a comment
calumgrant
left a comment
There was a problem hiding this comment.
Overall, the QL is clearly a great improvement. One thing I didn't understand is how the results have changed. I'm sure they're fine but it's quite hard to tell from the table of .expected output.
Contributor
Author
The reason for this is that the successor of a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last commit fixes a minor performance regression caused by #1486 (profiling report), most notable on mono. Performance report for this PR is here.